Fedyon

Results 12 comments of Fedyon

Correction: the working one is `-afm libvorbis -ac vorbis`, not in `-afm ffmpeg`. Setting `driver ffmpeg` `dll libvorbis` in codecs.conf doesn't seem to work.

The crash reproduced with `-vf expand=::::1 -vo md5sum` too. Perhaps `-vo directx` was not at fault, editing title.

Thanks everyone. Unfortunately, r38188 still crashes with the same reproducer. In attempt to reduce factors, I found that the same crash _can_ happen with `-demuxer rawvideo -rawvideo w=640:h=480:format=yuy2 -vf expand=::::1...

Well, consistency... perhaps yes. Yes, consistent, but not reliable. I mean... Full command line: `T:\TEMP\MPlayer-corei7-r38188+g6e1903938b>mplayer -noconfig all -nofontconfig -font mplayer\subfont.ttf -demuxer rawvideo -rawvideo w=640:h=480:format=yuy2 -vf expand=::::1 -vo null -osdlevel 3...

I believe the crash point is: https://github.com/sherpya/MPlayer/blob/fee36a534aee8fce8311c281ef049c3f51e9a789/sub/osd_template.c#L262 in particular the argument mmsrc, which is in turn https://github.com/sherpya/MPlayer/blob/fee36a534aee8fce8311c281ef049c3f51e9a789/sub/osd_template.c#L258 Disasm on MPlayer-corei7-r38188+g6e1903938b gave this: ``` 66 0f d7 c8 pmovmskb ecx,xmm0 81...

Result of guess-stack-rewinding. ``` vo_draw_alpha_yuy2_sse( 00000170, 0000003C, 0B7ECAB8, 0B7F2110, 00000170, 0B943268, 00000500 ) vo_draw_text_ext( 00000280, 000001E0, 00000000, 00000000, 00000000, 00000000, 00000280, 000001E0, 00484010 ) ``` That problematic `src` should have...

Wait, something is wrong. I think I found the compiled `alloc_buf`, but in there supposed-to-be-memalign is actually just plain `MSVCRT.malloc`! ``` 00522750 899388190000 mov [ebx+00001988],edx 00522756 893C24 mov [esp],edi 00522759...

@sherpya I'm afraid it looks like the _trick_ is not here, for whatever reason. I believe this is the whole of `alloc_buf` https://github.com/sherpya/MPlayer/blob/fee36a534aee8fce8311c281ef049c3f51e9a789/sub/sub.c#L150 ``` 005226B0 57 push edi 005226B1 56...

I just realized that I overlooked this, it certainly can break `src` alignment: https://github.com/sherpya/MPlayer/blob/fee36a534aee8fce8311c281ef049c3f51e9a789/libmpcodecs/vf_expand.c#L130 but I'm not sure what this path is doing at the first place... (rewrote; dst didn't...

Ah I see, so adding side borders is breaking them all. Thanks for the explanation. With MPlayer-corei7-r38188+g6e1903938b, I simulated the fix by setting breakpoints on 00522777 and 00522784 to make...