Federico Di Pierro comments

Results 1254 comments of


                                            Federico Di Pierro

fix(build): metrics compilation after refactoring into classes

Thanks Mauro for taking care of this!

fix(build): metrics compilation after refactoring into classes

It happens sometimes; probably mismatch between kernel headers package and runner kernel (or bugged headers package); rnothing to worry about for you! Restarted :)

fix(build): metrics compilation after refactoring into classes

Yes no problem, the issue is not dependent on your changes!

fix(build): metrics compilation after refactoring into classes

/milestone 0.39.0

fix(build): metrics compilation after refactoring into classes

Yep! I already tagged Gerald in that PR to ask him to double check ;) Not a big deal, we can wait and then bump libs and driver here once...

fix(build): metrics compilation after refactoring into classes

This is the same error we are gettng on #3283 . Needs further investigation... Also this and #3283 are basically the same, i'd close one of them (well this is...

new(config): add `container_engines` config to falco.yaml

I'd also add a debug print of enabled container engines during the startup of Falco ;)

new(config): add `container_engines` config to falco.yaml

> And / or likely more tests in libs make more sense given we just call some API here? Yes, agree! Also, you could add some tests to https://github.com/falcosecurity/testing/blob/main/tests/falco/config_test.go; for...

new(config): add `container_engines` config to falco.yaml

So, `TestFalco_Legacy_TimeIso8601` is failing because it sees: ``` Fri Jun 28 21:37:49 2024: Enabled container engine 'docker' Fri Jun 28 21:37:49 2024: Enabled container engine 'podman' Fri Jun 28 21:37:49...

new(config): add `container_engines` config to falco.yaml

Aside from :point_up: , LGTM!