Federico Di Pierro

Results 1254 comments of Federico Di Pierro

Hi! Thanks for opening this issue! By looking at the code generating the error, i can see that `u16` type is actually supported: https://github.com/cilium/tetragon/blob/main/pkg/selectors/kernel.go#L676 It resolves to: `GenericU16Type: "uint16",` string,...

Yep this is something that was fixed a month ago: https://github.com/cilium/tetragon/commit/865de200bb75d2be7fd5605a9fb8d4b35f0132c6#diff-27cf3aef45267b713359a8b5e3cbf2932e0d809290418cc042c7f000d01dbdd2 and was not part of latest release! See pr: https://github.com/cilium/tetragon/pull/4171

> Or using compatible in size integer type is official way to do that? Am not really sure, let me ask @mtardy :) Anyway, since it is literally an `unsigned...

> Tested several times: Question: were you able to reproduce the issue before your changes?

Oh @ariosmon i just noticed that the commit message is a bit off, seems like you should `amend` it!

Oh also, can you squash the commits together since they belong to the same logical commit?

> or would you prefer me to squash them locally in my fork so the PR itself shows only one commit? This one :)

Well, i cannot merge stuff :) Anyway, normally we wait for 2+ approvals, but in some cases (eg: very simple fix, or like this PR, a test-only PR) i've seen...

Hi! We have some tests that use these operators, eg: https://github.com/cilium/tetragon/blob/main/pkg/sensors/tracing/kprobe_net_test.go#L566, and they seem to work fine. Can you share the policy you are using?