Florian Bischof

Results 295 comments of Florian Bischof
trafficstars

We are positioning the popup over inline-style. How should this work without inline? https://github.com/Leaflet/Leaflet/blob/3d0d4b36cbbec7e1ae98dbf6f1a0b1db0237f227/src/layer/DivOverlay.js#L312

Sorry I didn't see it on the first review, but I can't merge this because it is no plugin, it is just a scrapping script for OSM.

Sure the idea is good, if you provide it in a look and feel like a Leaflet Plugin, I will add it. So what does this mean: * Don't create...

@BrekiTomasson would it be possible for you the create a demo? For example on www.leafletjs.com/edit.html And can you please test if it also happens without the `leaflet-realtime` plugin?

Before we dig more into this, can you please check if it is also happening with the latest version of Leaflet (1.9.4). And please try to setup a demo on...

I see the benefits but also the problem of having a bigger bundle. In my opinion we need to add in Leaflet more accessibility features, which includes translations and also...

> I'd try to construct polygon with both start and last points outside the screen. This should give reduced _parts arrays, and closestLayerPoint would find a point on the [last...

If we replace `_parts` with `_rings` everything works fine. https://plnkr.co/edit/J78vmzTx82kPh1Ck Perfomance could be still an issue, needs to be tested. @mourner @IvanSanchez @jonkoops do you see any problems if we...

> Please **revert** the not necessary changes like in the **Gemfile** and the comments in **v2.html**. I will not review your code again until this changes are reverted. Also please...

Everyone can work on it. The best PR will be merged. A few must-haves: - Working on mobile and desktop - Always visible on the screen and not only in...