Florian Bischof

Results 304 comments of Florian Bischof
trafficstars

In `v2` it would not apply because we already removed that we set the `leaflet-oldie` class. So yes we should remove the filters with `v2` too. https://github.com/Leaflet/Leaflet/blob/83fb5a4226e7c306631b3af7d3c5c96cc9a702f3/src/map/Map.js#L1106-L1112 Also it looks...

> Looking at the diff in this PR, I'm cautiously convinced this is minimal lift and minimal compute for a high impact use-case. I see it like this too. Over...

@jonkoops @mourner @IvanSanchez I would be nice to have your input too but if you have no time to review, please give your OK that we implement translation in Leaflet...

I don't know what to think of the library yet. It is very difficult to debug, the manual server keeps crashing and apart from the documentation there is hardly any...

Saddly not. It simply terminates the command: > ![grafik](https://github.com/Leaflet/Leaflet/assets/19800037/96247679-8765-470e-92fc-013330d891fb) Now I commeted out a line `Icon.Default.js` and then I added a `debugger` to a test. Maybe it has something to...

I mean that i saw that we can run the test files parallel

`npm test` works for me on Windows. ![grafik](https://github.com/Leaflet/Leaflet/assets/19800037/50c2e499-ccbb-4aef-ac5d-87c3ad0bf110) Without any investigations: It is interessting, that Firefox runs 7 tests more.

Did you do a re-build? `npm run watch`

no, you did it correct. First build and then test. I will check it the next days by myself. In the mean time you can merge the latest commit from...

It looks like this could be working because of: https://github.com/Leaflet/Leaflet/blob/bbd264704b05036a281bd44513cf1760d8336b9d/src/layer/tile/GridLayer.js#L691 But I'm not sure if this makes maybe some problems with other plugins. @IvanSanchez @mourner what do you think?