Fabien Péan
Fabien Péan
Summarizing earlier discussion: The new approach to use algorithms, e.g. `InteractionDynamics` pushes implementation details knowledge requirement on users and does not prevent misuse. For example, someone using `InteractionDynamics` instead of...
Adding another body to an existing example and putting 2 different contacts relation for different point in time.
https://github.com/Xiangyu-Hu/SPHinXsys/blob/e5d224d7af1d0685165e45224ecc50d65186f5cc/SPHINXsys/src/shared/bodies/base_body.h#L137-L144 Restart is inherently broken with new particle generation approach. For any particle generator, `initializeOtherVariables` happens after the function implemented by the user, the initialization of extra variable based on...
The registration and memory management of particles field has been changed recently to move as many field out of `base_particles.h` These changes have some consequent side effects due to the...
## Description  The cantilever beam can be found [here](https://en.wikipedia.org/wiki/Deflection_%28engineering%29#Uniformly-loaded_cantilever_beams). In the Euler-Bernoulli formalism, a rigid cross-section orthogonal to the centerline is assumed, so for isotropic linear elastic material, it...
https://github.com/Xiangyu-Hu/SPHinXsys/blob/190d0ef53122fb33e0dfb229f56ab0b2980b059d/SPHINXsys/src/shared/particle_dynamics/solid_dynamics/constraint_dynamics.cpp#L255-L264 Registering the variable prevents using several of this type of constraint in a single simulation because it leads to error if it is constructed more than once for the...
https://github.com/Xiangyu-Hu/SPHinXsys/blob/890f4ded058d7e1e6185972aaef2e3494750e094/SPHINXsys/src/shared/particle_dynamics/solid_dynamics/contact_dynamics.cpp#L114-L129 Before I forget again, the above snippet for shell contact calculation has several issues for the generalization in 3D: 1. The algorithm sample along a line (correct in 2D),...
https://github.com/Xiangyu-Hu/SPHinXsys/blob/1e0042b5040c6f59b9fa98e7634c33f63090fd1a/SPHINXsys/src/shared/particle_dynamics/solid_dynamics/solid_dynamics.cpp#L770-L778 While considering vectorization and see how it could fit, I ended up thinking specifically about this part of the code above. This kind of loop is suboptimal as it...
[skip ci] This is a code review done while browsing through the code for learning the inside of sphinxsys. Open for discussion @Xiangyu-Hu @mrezavandVirtonomy
@Xiangyu-Hu The cause has been identified. It is an issue with vcpkg with CMake 3.29.1. It will fix itself in coming days (1) as soon as vcpkg upgrade the CMake...