Fabiano Soares Honorato

Results 14 comments of Fabiano Soares Honorato

@jamengual I've reproduced the behavior in [this pull request](https://github.com/Fabianoshz/atlantis-test/pull/3). The terragrunt code itself it's not working but it's possible to see that another directory unrelated to the PR can be...

In this case yes, to explain further, different teams working on the same repository might try to plan and apply resources that don't belong to them.

Yes, it's possible to open a PR with an empty line but if that's the case we can prevent that user from applying by enforcing a code owner of that...

Hi @nitrocode, I'll take a look at this this week.

Sorry for my absence, I've had some personal issues. Came back today and managed to add the logic to projects too but I'm still not satisfied with the code yet.

@nitrocode @jamengual how should I approach writing a test for this? Looking at the code [here](https://github.com/runatlantis/atlantis/blob/main/server/events/project_command_builder_test.go#L417-L433) the values are defined for all the cases but since this is a server...

Ok, I'll try to add the tests tomorrow.

Tests added, I believe this should be good to go, sorry this took more time than I expected.

Hey @nitrocode, I sure want to contribute more, I'll reach out on slack!

Just sharing to maybe help while AWS don't have an official way to customize addons. My use case is adding nodeSelectors and tolerations to coredns to ensure they get scheduled...