GuangyuFan

Results 18 comments of GuangyuFan

> @FGYFFFF Thank you! Are you able to add some tests around this, too? If not, I'm happy to pick up the work. @meatballhat I will add unit tests later.

> > @meatballhat I will add unit tests later. > > Did you mean you will be adding tests as part of this PR? Yes! Do I add a test...

> Tested this PR with my project. Unfortunately, it does not fix the original issue. Disabling > > https://github.com/urfave/cli/blob/0c9527f4b7f5618832c90d8b6c1ead4b7b1e2a80/category.go#L163 > > and > https://github.com/urfave/cli/blob/0c9527f4b7f5618832c90d8b6c1ead4b7b1e2a80/category.go#L126 > > worked. If your flag...

I don't think we're talking about a problem. If you declare a flag that defines a "category", then the flags under that "category" grouping need to be sorted. For example:...

> > But if you don't specify "category", then all flags should not be sorted: > > That is correct. I have defined my flags in the following order: `host`,...

@meatballhat Hey, friend!!! I've thought about this piece of code and I don't think I need to write unit tests, can I merge it in? My code currently relies on...

在最开始解析包名的时候,为每一个同名的 package name 都进行一个序号递增的重命名

删除掉冗余的tag,thrift和protobuf采用同样的策略。 等待 thriftgo no_json_tag 特性合入&发版中 [51](https://github.com/cloudwego/thriftgo/pull/51)

@Haswf Thanks for your advice! I will answer you based on your three questions. - All templates are available at [hertz-example](https://github.com/cloudwego/hertz-examples/tree/main/hz/template) and the documentation I should not mark. And there...