Fabian Albert comments

Results 38 comments of


                                            Fabian Albert

PQC: Classic McEliece

Rebased to master.

PQC: Classic McEliece

Cleaned-up history.

Kyber constant time division

Closed. See #3959.

HSS-LMS Signature Algorithm Implementation

This PR is now ready! Any review is welcome ❤️

HSS-LMS Signature Algorithm Implementation

Thanks again for your review, @reneme! I addressed your suggestions in https://github.com/randombit/botan/pull/3716/commits/a4c5df28bc9126a3f4de5fc3b02ec523863184a4.

HSS-LMS Signature Algorithm Implementation

Thanks for your detailed and comprehensive review, @reneme 👍 I addressed your suggestions in 1f3befe.

Abstraction Layer for Hybrid KEMs

Rebased to master

Abstraction Layer for Hybrid KEMs

Rebased to master.

Abstraction Layer for Hybrid KEMs

Thanks for the review. I agree that loops are easier to read here. It's quite sad that these C++ iterators are so bulky :( I addressed your review comments.

Abstraction Layer for Hybrid KEMs

I also made the KEX to KEM adapter header public. This is very useful for applications using non-predefined KEX algorithms with KEM combiners. Let me know what you think.