Fabian Albert
Fabian Albert
In order to finally close this issue ticket, I sum up the fixes and observations we made regarding the findings discussed here. ### Session not aborted >[C] when a server...
@reneme We have two open TODOs regarding the bitvector. 1. We would like to use the bitvector with strong types. Currently, the most annoying thing is that we need to...
Thanks a lot for your extensive review, @reneme! I addressed your suggestions and am optimistic that this PR is ready to drop its Draft status 🎉. Note that some suggestions...
I cleaned up the git history and rebased to master.
Thanks very much for your initial review 🚀 I'll look into it.
I rebased to master (which removes the --no-stdout flag commit).
> Especially, the coverage build time suffers quite a bit from the new tests. Yeah. `--run-long-tests` tests all tests with all instances. If you think this is problematic, here are...
Rebased to master + commit with some left-over suggestions.
> 1. We may only want to test some instances in the keygen tests. The correctness of the keys is already covered in the KAT tests; only the Botan interface...
> @FAlbertDev This needs another rebase. Also, with https://github.com/randombit/botan/pull/3985 merged, it'll need to implement the new method Public_Key::raw_public_key_bits() as well as the method PK_Key_Generation_Test::public_key_from_raw() in the CMCE_Generic_Keygen_Tests test case. Done!...