Kang-Che Sung (宋岡哲)
Kang-Che Sung (宋岡哲)
> ```c > Row.c:511:13: warning: 6th function call argument is an uninitialized value [core.CallAndMessage] > 511 | len = snprintf(buffer, sizeof(buffer), "%c/s ", unitPrefixes[unitPrefixIndex]); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/x86_64-linux-gnu/bits/stdio2.h:77:3: note:...
> > Also, the space before `B/s` is intentional to ease reading `8B/s`. Which can be hard to discern with some console fonts. > > Should there be space for...
@AryanGitHub > I believe the disk read speed in htop on Linux is never between 1 and 1024 bits/s. Instead, the speed was observed to be between 0 and 1...
@savchenko You should adjust the color palette of your terminal emulator. It isn't something we can adjust in htop's side. IMHO, we could have an alternative of using white text...
I found one possible room for improvement: EDIT: This is done in a separate commit. ---- In the static build of htop (see [this CI build log](https://github.com/htop-dev/htop/actions/runs/10258721630/job/28381996376)), `-ltinfo` is sometimes...
> Please don't use `draft` in a commit message. Commits should aim to be "the final product". If the patch series overall is not ready for merging yet, that's what...
The configure script is revised and ready. However I got an unexpected configure error in OpenBSD build job in CI. It seems that OpenBSD build system in CI has `pkg-config`...
> There's also a failure for Solaris AFAICS. Any intel on that one? @BenBE I was testing whether htop can build on all BSD systems and Solaris with `pkg-config` installed....
Since there are changes in this PR that look not trivial. Would you guys mind if I pick some of the easier changes and file a new PR for them?...
Minor note: Solaris 11.4 in our CI build jobs supports pkg-config, but the system doesn't seem to come with pkg.m4. So the warning would always exist if you generate htop's...