Kang-Che Sung (宋岡哲)
Kang-Che Sung (宋岡哲)
> According to this in 2001 Linux switched to 32bit and it is unsigned. > > Now - assuming there is a reason to have a signed UID - it...
> There'S a lot of noise introduced due to the `(size_t)len` casts on `RichString_appendnAscii` calls, most of which could be avoided if we made `xSnprintf` return `size_t`. Can you take...
> Granted, you have done nice, small commits and for 3-4 of them there is a rationale, like "Fix potential out of bound access" or the N-in-Unicode != N-in-Ascii. I'd...
@BenBE I have a question to ask when I try to improve the code of `RichString`... I can't get the idea of what the commit a6306f090abcb1316a81444dc5514d236409349b (#1434) was trying to...
@BenBE I still didn't get how the leak can happen. For what I've known, the `chlen` property is only controlled by the `RichString_setLen()` function. Unless `chlen` is modified from outside...
Just wondering, why was this meter called FlexMeter? Was it a random name you thought of? `pcp-htop` has a PCPDynamicMeter. And it seems this PR is about a dynamic meter...
Before I review more about the code style and quality of the meter, I have some general comments: 1. **How do we indicate the user has permissions and intent to...
> In other words, I wish the FlexMeter template files be shell scripts themselves, with appropriate shebang and execute permission (mode) bits. This would help the security in the long...
> @Explorer09 What do you think about handling group and user sticky bits on the files? How to handle symlinks? * Sticky bit for executables are largely irrelevant for our...
> 1. Regarding the permissions of the Meters - I think we can stick with permissions which used for SSH I didn't get this. Would you explain? > 2. For...