Evan Lovely

Results 51 comments of Evan Lovely

Since PR #319 was merged; perhaps this issue could be closed?

Yep, me too - pretty sad to see this on my first experience

OK, so it looks like plugins have the ability to "enable" and "disable" themselves by firing off a cli command that alters the `patternlab-config.json` for you: `enable.js`: https://github.com/pattern-lab/patternlab-node/blob/4556fc7d12a1d11b401821919ff2f3ddc5658c93/packages/cli/bin/cli-actions/enable.js#L33-L34 There's one...

Well, crap 💩 this will be a tough refactor with those in there. Perhaps keeping it json and then passing the string paths we get from it through `resolvePkg` might...

OMG! The UI kits resolve those paths already relative to where they are! All this time I thought that `../uikit-workshop` was going up and out of the the `edition-twig` directory...

This would be super helpful!!

@tanc We've got this fixed over in our fork of this: https://github.com/drupal-pattern-lab/patternengine-php-twig/pull/1

Hmm... now that I'm looking at this closer, I'm not too big of a fan of making a new Twig Extension for each global file. I'd prefer if we just...

> @bradfrost @EvanLovely in your experience working with clients, do you find yourself demoing whole patterns WITH annotations? I have not. Honestly... never! I always think they are awesome though...