Eugene Chung

Results 10 comments of Eugene Chung

This problem is originated by the PR https://github.com/getredash/redash/pull/6685 . I think it's made huge interoperability problem.

I suggest to use orjson. It allows nan, too. In general, it's faster than json and simplejson.

@arjunsalyan Nope. You must use 8 or make your own redash image that #6685 is reverted.

@arikfr - As you know, the built-in json.dumps(allow_nan=True) (default bevaviour) writes NaN value as `NaN` string and allow_nan=False makes an error. - orjson without any options writes null instead, which...

I thought it's a just simple patch so that I didn't need to build it by myself. I will build and resolve by myself.

Fortunately, EMR 7.1.0 fixed the problem. ``` Welcome to ____ __ / __/__ ___ _____/ /__ _\ \/ _ \/ _ `/ __/ '_/ /___/ .__/\_,_/_/ /_/\_\ version 3.5.0-amzn-1 /_/...

```py (venv) ~/project/private/redash git:[master] ruff check --fix tests/test_utils.py warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in...

@eradman Yes. As I [commented](https://github.com/getredash/redash/pull/7391/files#diff-2bf05498a23be7d4ef69a44534118e8a822a84590e109e24de4c9e63b1803d74R145), orjson always uses compact separators. I'm going to fix the test.

Passed all failed tests. ![image](https://github.com/user-attachments/assets/dc593194-6591-4e9e-b207-0225756e082d)

The Java world provides this mechanism as the sources of libraries are provided as zip files. The zip file system is naturally read-only.