Eiichi Tsukata comments

Results 5 comments of


                                            Eiichi Tsukata

Fix job dequeue order with explicit ORDER BY

Hi @karupanerura Taking another look at codes, I came to think that the ORDER BY should use the column `job.enqueue_time` instead of `job.id` because `reenqueue` updates `enqueue_time`. How do you...

Fix job dequeue order with explicit ORDER BY

Ref: http://dbz-dokkan.bngames.net/info1116.html

unpack: use lazy alloc to avoid large array/map OOM

> if an user tries to unpack untrusted msgpack-encoded input * an example code : https://metacpan.org/release/HTTP-Session2/source/lib/HTTP/Session2/ClientStore2.pm#L81

Fix default dump file permission : 0666 => 0600

* Ref * SEI CERT : FIO06-C. Create files with appropriate access permissions * https://wiki.sei.cmu.edu/confluence/display/c/FIO06-C.+Create+files+with+appropriate+access+permissions

Fix default dump file permission : 0666 => 0600

This PR does not mean the current implementation is vulnerable to symlink attacks. Because the sticky bit is usually set on `/tmp` and `sigdump` uses just `/tmp` (not sub dirs...