Ethan Williams

Results 13 comments of Ethan Williams

> propose and implement a mode where each crate can be documented separately then stitched together (cross referencing, search index creation, etc.) in one final, hopefully lightweight, step. Hello! I'm...

@jsha, I love that there are more use cases than we initially anticipated! I agree that the intermediate cross-crate info should be written in JSON, and for the merge step...

Updated the RFC with the items mentioned in [my previous comment](https://github.com/rust-lang/rfcs/pull/3662#issuecomment-2184163681). I chose the name `--merge=write-only` instead of `--merge=no-read`

I updated the RFC + [WIP implementation](https://github.com/rust-lang/rust/compare/master...EtomicBomb:rust:master) so that `--include-info-json` and `--write-info-json` take a path directly to a crate-info.json file. The existing `tests/rustdoc*` suite passes my WIP implementation. That hopefully...

I added an `--include-rendered-docs=` flag that will copy the docs from an externally documented crate to the current `--out-dir`.

Updated the RFC and my implementation with `--include-rendered-docs`, a `version` key in `crate-info.json`, and `--merge=read-write`.

About the complexity concern, I am on board with most of the suggestions! As far as I can tell, the diff from the current RFC is relatively minimal? * Rename...

I changed the following to simplify the interface as suggested by @camelid: * Rename `--merge=none|read-write|write-only` to `--merge=none|shared|finalize` * `--write-info-json=target/doc.parts/my-crate/crate-info.json` -> `--parts-out-dir=target/doc.parts/my-crate` * `--include-info-json=target/doc.parts/my-crate/crate-info.json` -> `--include-parts-dir=target/doc.parts/my-crate` * Clarify the section that...

Thank you for the review Manish! I made some small changes in response! * Summarize current behavior of rustdoc in Reference-level explanation * Flag summary in Guide-level explanation * Say...

Thank you for the review @camelid! I addressed the new feedback: * Remove the `--include-rendered-docs` flag * `--parts-out-dir` restricted to `--merge=none` * `--include-parts-dir` restricted to `--merge=finalize` * `crate-info.json` -> `crate-info`...