jellyfish

jellyfish copied to clipboard

The current `run_benchmarks.sh` script lacks flexibility and robust error handling. Here are some suggestions for improvement : **Add Options for Specific Benchmarks**: Allow users to specify which benchmarks to run...

deseti

feat: add keccak256 merkle tree

3

### This PR: - introduce macro rules `impl_mt_hash_256!` for implementing boilerplate for node and digest for MT that has 32 bytes output size - impl for both Sha3 and Keccak256...

alxiong

Currently `Advz` construction enforces that `recovery_threshold` and `multiplicity` must be powers of two: https://github.com/EspressoSystems/jellyfish/blob/7cd4f76b0844d4efdf9179fcdd7d4cae44bf7400/vid/src/advz.rs#L176-L185 Code comments link to #339 in several places but do not explain why this issue blocks...

ggutoski

A *reference test* ensures that new code changes do not break backwards compatibility for serialization of certain data structs. We should add such tests to `jf-vid` package, and probably others,...

ggutoski

**Not meant to merge into `main` !** Keep this as a draft PR to track the changes made.

alxiong

- [ ] https://github.com/EspressoSystems/jellyfish/blob/main/merkle_tree/src/lib.rs#L232-L236: verification should be taking `Self::Commitment` instead of a `NodeValue`. - [ ] [MAYBE NOT] https://github.com/EspressoSystems/jellyfish/blob/main/merkle_tree/src/internal.rs#L101: `MerkleTreeCommitment` should have an API to verify a `MerkleProof`. Same for...

mrain

`MerkleProof` should not include position or leaf value

4

This issue is an opinionated suggestion. Others may disagree. `MerkleProof` struct contains: - 2 copies of index position - leaf value These items should not be in the merkle proof....

ggutoski

jellyfish benches build break with --no-default-features

3

I'm unable to build jellyfish benches with `--no-default-features`. The feature `parallel` is on by default so I cannot run benches without `parallel` feature. Much confusion. Why is `parallelizable_slice_iter` returning a...

ggutoski

test: add test hook to corrupt share index

2

closes: #XXXX ### This PR: This PR adds a small testing function to corrupt VID share indices. The purpose of this function is to create VID shares that fail `verify_share`...

elliedavidson

Add constructor for jf_vdf::MinRootElement

1

Can't create MinRootElement Object when use jf-vdf crate

zilong-dai