jellyfish icon indicating copy to clipboard operation
jellyfish copied to clipboard

feat: refactor Merkle proof for ergonomics

Open mrain opened this issue 4 months ago • 7 comments

closes: #642, #658

This PR:

  • Remove leaf information (index, element) from the MerkleProof struct.
  • Change the verifications APIs to take a Merkle commitment instead of a simple root digest.

This PR does not:

Key places to review:


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (main)
  • [ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [ ] Wrote unit tests
  • [ ] Updated relevant documentation in the code
  • [ ] Added relevant changelog entries to the CHANGELOG.md of touched crates.
  • [ ] Re-reviewed Files changed in the GitHub PR explorer

mrain avatar Oct 15 '24 22:10 mrain