jellyfish icon indicating copy to clipboard operation
jellyfish copied to clipboard

feat: Add BLS signature short pk variant

Open alxiong opened this issue 2 years ago • 3 comments
trafficstars

Description

Major changes include:

  • move current bls_over_bn254 impl to bls_over_bn254::min_sig
  • add bls_over_bn254::min_pk module

closes: #373


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against correct branch (main)
  • [ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [ ] Wrote unit tests
  • [ ] Updated relevant documentation in the code
  • [ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the GitHub PR explorer

alxiong avatar Sep 28 '23 12:09 alxiong

Is this still working? We may still want a short pk version for a smaller stake table. cc @alxiong

mrain avatar Oct 09 '23 16:10 mrain

I see! I paused this previously, but I will keep working on it this week. Thanks for reminding me! @mrain

alxiong avatar Oct 10 '23 13:10 alxiong

I see! I paused this previously, but I will keep working on it this week. Thanks for reminding me! @mrain

Thanks @alxiong ! Let me know when it's ready.

chancharles92 avatar Oct 12 '23 18:10 chancharles92