espresso-sequencer
espresso-sequencer copied to clipboard
EspressoSystems
- include changing the timestamps too (currently only blocks are changed)
Affected Code: LightClient.sol (line 441) Summary: The function setstateHistoryRetentionPeriod wrongly when reducing the retention period, which can lock in a large value if set by mistake. Suggestion: Instead of reverting...
This is a very useful thing for node operators to be able to understand and analyze
Closes #1968. Closes #1969. ### This PR: * Add tests for transaction submissions via public mempool with reserve and fallback builders. * Combine and refactor tests for public and private...
Affected Code: LightClient.sol (line 424) Summary: The current implementation of getHotShotCommitment includes an unreachable return statement. Suggestion: We recommend to refactor the unreachable return state- ment.
Affected Code: LightClient.sol (line 355-L399) Summary: The current implementation allows for index 1 to be checked and will mark prevUpdateFound as true if the condition is satisfied. Suggestion: Consider either...
Closes #2072 ### This PR: - validates the state history retention period upon contract initialization ### This PR does not: - set a max state history retention period, it will...
Should return the balance as a plain integer, not a tagged base64 encoded field element
see comment: https://github.com/EspressoSystems/espresso-sequencer/pull/2095 The test should add an entry to the database with the correct commit but an incorrect data field, i.e., the data field produces a different chain config...
see comment: https://github.com/EspressoSystems/espresso-sequencer/pull/2091#issuecomment-2388417560