espresso-sequencer icon indicating copy to clipboard operation
espresso-sequencer copied to clipboard

L02: Implementation of lagOverEscapeHatchThreshold deviates from comment

Open alysiahuggins opened this issue 1 year ago • 0 comments

Affected Code: LightClient.sol (line 355-L399)

Summary: The current implementation allows for index 1 to be checked and will mark prevUpdateFound as true if the condition is satisfied.

Suggestion: Consider either moving the if condition (on lines 381-383) at the start of the while loop (on line 375), or modifying the code sim- ilarly to the provided implementation which also improves on read- ability

alysiahuggins avatar Sep 26 '24 13:09 alysiahuggins