Yan Zhang

Results 232 comments of Yan Zhang

It looks acceptable. PR is welcome 😄, and please also update the corresponding section in README for the new config schema.

Here is a misunderstanding of setting `maven.terminal.useJavaHome`, it's indicating whether you are going to use value of setting `java.home` as your JAVA_HOME... You can set it to `false`, and have...

Sorry about the misleading. If you want to use a specific JAVA_HOME, you can either: * set `maven.terminal.useJavaHome` to true, and set `java.home` in settings.json or * (recommended) simply use...

@jahan01 try printing out the values in `.zshenv` like below, which somehow proves my hypothesis above. ``` echo before:$JAVA_HOME export JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-13.jdk/Contents/Home echo after:$JAVA_HOME ``` I'm not familiar with zshell, but...

OK, then I think it can be a regression introduced by https://github.com/microsoft/vscode-maven/pull/240 . Previously it manually executed "export" statements for different kind of shells. So no matter what was written...

@thakkarparth007 Thank you for reporting this. When did you see this error, and what's the full error message?

Thanks, it's very helpful for locating the problem. The problem is, Maven requires you to set JAVA_HOME env (e.g. to run `mvn` commands), and you don't have the JAVA_HOME set...

BTW, I just searched vscode's repo for zsh issues, check if https://github.com/microsoft/vscode/issues/143061 helps?

These files are not generated by VS Code Maven extension, but by Java extension. See https://github.com/redhat-developer/vscode-java/issues/618 and a WIP improvement https://github.com/eclipse/eclipse.jdt.ls/pull/1900 As for which projects to import, an ideal approach...

/cc @jdneo who is working on related improvements.