Yan Zhang
Yan Zhang
Thank you for the information. But as I mentioned, I cannot reproduce it myself. The only way I can think of is, to create a private build of my product,...
Great appreciation. I'll create one more private build, still using `execa`, adding `shell:true` and quoting the path (suggested by [child_process doc](https://nodejs.org/api/child_process.html#child_process_spawning_bat_and_cmd_files_on_windows)). - BTW, as execa declare to [have better Windows...
For better designing the API, let me briefly introduce how IntelliCode (probably the first consumer of this contribution point) ranks the items. To make smarter ranking, it needs to know...
Semantic highlighting is already supported, and jdtls will report tokens and corresponding modifiers to clients. Color themes will recognize and colorize them. Not sure what do you mean by "its...
Like I mentioned above, LS is responsible for reporting correct token type and modifier information, and theme authors are responsible for colorization based on the information. For example, they are...
I notice some change about `textDocument/completion` request in LSP 3.16. LSP 3.15: > The request can only delay the computation of the detail and documentation properties. Other properties like sortText,...
> /* The `insertText` is subject to interpretation by the client side. * Some tools might not take the string literally. For example * VS Code when code complete is...
@fbricon Yes, you are right. The "complete insertText + resolve textEdit" approach happens to work in some cases, but the correctness is not guaranteed. I created the #1868 mainly to...
I simply think if I commit the completion before `textEdit` is resolved, client can simply use `insertText`(or label) and ignore the later resolved `textEdit`...which is not a big problem to...
Below is the call tree after applying this PR.  Let's compare it with https://github.com/eclipse/eclipse.jdt.ls/issues/1864#issue-984648697 , using `unit.codeComplete` (which we assume is taking a fixed amount of time) to calibrate....