Erwin Junge
Erwin Junge
Apparently I failed at running black :facepalm: I've fixed the codestyle and forcepushed a new commit.
> dang! thanks for the contribution @ErwinJunge ! I'm wrapping up a bunch of work stuff, but I'll review this over the next few days. Thanks! For me this is...
@econchick friendly ping on the review :)
Hi @econchick , I'm sorry to hear about the covid and I hope you had a full recovery! You're welcome for the PR. The test suite could indeed use some...
Tests updated in latest push. Re: pycon US, thanks for the offer but I don't think that'll be likely :) I live in the Netherlands, and it's currently a bit...
@econchick those test failures look like the docstring coverage results are different on windows than they are on linux :confused: I don't have a windows box available to run those...
@econchick do you have some input on the windows tests? Is there perhaps something I can do without having access to a windows box?
@econchick I took a closer look today and what's failing are the test expectation files in `tests/functional/fixtures/windows/` I didn't update those (because I got all green on my machine :sweat_smile:...
@econchick friendly ping on the above :) Please let me know if there's anything I can do to move this along.
:wave: @econchick please don't forget about this one :pleading_face: