Erik Pellizzon
Erik Pellizzon
I recommend reviewers to squash the commits
> It's probably easier if you use a slice of bufferEntrys. That slice could then start at length 1, and we'd append every minute, until we reach the maximum length...
5 is fixed or is the number of minutes chosen by the user?
In the fraction, what represents token.IsRetryToken == false? From the name I think that it's a boolean that says if the user sent the correct retry token, but in that...
> Hi @marten-seemann, we finished the implementation and were working on testing the new feature. We are a bit confused about the testing part, mainly on these points: > >...
> Adding a bit of context here: > * Opening a QUIC packet and starting a TLS handshake is expensive. One attack on a QUIC stack is to flood the...
I missed a thing, the callback function is called before or after the retry mechanism? Reading better the function it seems to me that it's used in both the cases....
> > Both the minutes and the percentage have to be set from the caller? > > We should probably provide reasonable defaults, and then provide a way for the...
Ok, we made an implementation in a [fork](https://github.com/fulviodenza/go-libp2p). Do we need to test it and, if yes, how? Is there some standard test for a real usage case?
Scrypt has nothing to do with it. In the constructor you have to change networkPrefix from '00' to '30' and in getPrivatePrefix() change return from '80' to 'b0'.