Eric Soroos

We need a changelog entry, but otherwise LGTM.

Looking at using this to additionally decorate some information about the JSON dump, and I think it would be useful if there was an option to pass additional information into...

I'm happy enough to push this -- I've reviewed all except for the example XLS writer plugin. The comment above is mainly extending this to fit the use case I...

Is this always going to return the final inserted version of the data -- e.g. upsert with two records containing the same primary key.

One option for the upsert (which would greatly improve the performance) would be to do: ``` insert into table (fields) values (values) on conflict (unique_fields_list) do update field=excluded.field, field2=excluded.field2, ......

`INSERT ... ON CONFLICT` is postgresql's version of upsert, and it's been in since 9.4 or so. So yes, one command. but you do need to specify which columns you're...

Unfortunately, this errors with dsaudit -- setting the include_records to default to false means that by default, anything passed through `datastore_upsert` is just going to be a bare response for...

There's quite a lot in ckan/ckanext that break a strict CSP, or at least, require the use of unsafe-inline in script and css. Just CSS: ``` File: ./ckanext/datatablesview/templates/datatables/datatables_view.html 86 29...

I'm seeing about a 2x speedup on my system with a 1.5M row dataset. (In this case, 5 vs 10 sec)

> I was hoping to fix the issue of duplicated/missing rows that can happen when a rows are added/removed while a dump is running. The only reliable way to do...