Eric Buehler
Eric Buehler
Hi @BenjaminBossan, I think this is ready for review.
Thank you, I work on some example code to reproduce the behavior and will raise an issue. Regarding examples of X-LoRA, we have put together some examples using the `xlora`...
I was able to put together a small example which shows how one would use the API as documented [here](https://github.com/EricLBuehler/xlora?tab=readme-ov-file#api), which I have attached in a plain text file as...
Thank you for trying it out. I ran the following code on a local machine with the latest installation from this branch to test the loading of a normal LoRA...
I found the bug: it was because of a mistake in a `hasattr` check. I added this because an `XLoraModel` should not have a default adapter injected. Perhaps you could...
I have now fixed the merge conflict.
Hi @BenjaminBossan, I'm not sure if you have had a chance to look at the updated PR, as merge conflict has been resolved, and I think it is ready for...
Thank you for your review! I have updated the code with your suggestions. - **How is the X-LoRA adapter trained? Could you please provide an example? Eventually, we'll want to...
Thanks for checking in, I have been working on optimizing + supporting efficient inference for X-LoRA. I just updated the code via your comments, as well as adding back in...
Sorry for all the issues! I've updated the code according to your recommendations (including formatting), and the test runs. About inheriting from `LoraModel` vs `BaseTuner`, it is certainly not the...