Eric Buehler comments

Results 543 comments of


                                            Eric Buehler

Can lora also be implemented with stable diffusion?

It is necessary to port all the files which need to be modified, depending on the structure. If the modified types are depended on, then it is necessary to port...

Can lora also be implemented with stable diffusion?

@oovm, no, but you can do it by adding: ```rust #[replace_layer_fields] #[derive(AutoLoraConvert)] ``` to each model struct.

Quantized: Use cublas for prompt

@lucasavila00, that's amazing! I am looking forward to merging this. Can you please add the special matmul function to the layer.rs file so we can use it in all models?...

Quantized: Use cublas for prompt

@lucasavila00 sure, I just updated it.

Add topk scalings, topk softmax scalings for X-LoRA

Refs https://github.com/huggingface/candle/pull/2132

Default values in enum struct-variants

@Icxolu, I think that looks great! Do you plan to open a PR?

Create new fine-grained enum for `build_cast`

Maybe this can be done with a macro on `InstructionOpcode` that adds the variants in, say, `CastOpcode`?

Integrate mistral.rs LLM

Thank you! I've removed formatting the whole codebase and just formatted my new changes.

Integrate mistral.rs LLM

@nerdai, I addressed your comments and have added you to the repo.

Integrate mistral.rs LLM

@nerdai, sorry for that mistake. It should be fixed now.