Eric Cousineau issues

Results 124 issues of


                                            Eric Cousineau

[bazel] Should avoid allowing `/usr/local` to (automatically) leak in

`/usr/local`, at least on Ubuntu, means someone custom-built something and exposed it at system-level, and it may end up shadowing / conflicting with sibling and downstream packages. https://github.com/RobotLocomotion/drake-ros/blob/f63677984fccd4da4ab6e2950939346f02f60c9f/bazel_ros2_rules/ros2/resources/ros2bzl/scraping/ament_cmake.py#L83-L84 We should...

colcon: Unclear how to conveniently inspect test outputs locally

When filing the prior slew of issues against `colcon` issues, I found myself a bit confused on how to test things locally and *quickly* inspect the output. ## TL;DR Through...

test_drake_ros: libdrake.so cannot be found if using `source ./install/setup.bash`, but can run otherwise

Trying to fix CI for https://github.com/RobotLocomotion/drake-ros/pull/153 ## CI Failure Looking at this failure: https://github.com/RobotLocomotion/drake-ros/actions/runs/3280593631/jobs/5401564148 ``` 6: - /__w/drake-ros/drake-ros/ros_ws/build/drake_ros_core/test_drake_ros --gtest_output=xml:/__w/drake-ros/drake-ros/ros_ws/build/drake_ros_core/test_results/drake_ros_core/test_drake_ros.gtest.xml 6: /__w/drake-ros/drake-ros/ros_ws/build/drake_ros_core/test_drake_ros: error while loading shared libraries: libdrake.so: cannot open shared...

ci: Unknown failures saying `operation was canceled`?

I am seeing `drake-ros` CI failures of such as this: https://github.com/RobotLocomotion/drake-ros/actions/runs/3278010676/jobs/5395926147 ```Invoking: bash -c,source /opt/ros/rolling/setup.sh && colcon lcov-result --initial /usr/bin/bash -c source /opt/ros/rolling/setup.sh && colcon lcov-result --initial Error: The operation...

rmw_isolation: Should improve defects for kwargs, config file uniqueness, module not being used

From discussion w/ @ggould-tri, identified the following defects (67151b8) - [ ] The usage of `scratch_directory` can be confusing, esp. in terms of "where should entropy go" from user's perspective....

ROS_DOMAIN_ID, ROS_LOCALHOST_ONLY: Unexpected behaviors?

I can reproduce Shane's results from #98 (but replacing `bazel run //ros2_example_apps:oracle_cc` with `bazel-bin/ros2_example_apps/oracle_cc`). However, I have run into odd edge cases. First, I confirm that using `ros2 multicast send`...

Should ensure dependency ordering closely matches that of CMake; ensure shadowing is accounted for

- [ ] For target dependency ordering, ideally we have a (stable) order that reflects the same ordering as in CMake, at least in Starlark (unclear what may happen once...

Should remove as many hard-coded paths from generated shell files

At present, I see things like ``` for workspace in ~/.cache/bazel/_bazel_{user}/{hash}/external/ros2/ros2-linux; do ... ``` I don't believe we should be using absolute paths like this. I suggest we use `${BASH_SOURCE}`...

rmw_isolation: Should ensure that traffic is isolated to local machine, regardless of network interfaces

In reviewing `rmw_isolation` for #125, I am now unsure if current `rmw_isolation` code is actually restricted to a local machine, e.g. for eclipse dds: https://github.com/RobotLocomotion/drake-ros/blob/c7f9c362c5b4f2071235e61bc64f8ac1ad0c42f5/bazel_ros2_rules/ros2/resources/rmw_isolation/rmw_isolation.py#L149-L150 For contrast, in Anzu, we...

Should ensure adding new packages doesn't incur rebuild for existing packages

Not sure if this is expected, but when I added things like `ros2cli` to Anzu, it triggered a rebuild of several C++ programs. I would not expected `ros2cli` to affect...