Erdogan Seref

Results 20 comments of Erdogan Seref

The button serves as an achievement.

Which approach should we choose?

I want to work on the issue but I don't know what the outcome should be. One use case is login via a Google account. So on the login page...

I provide an example to better understand the issue. ``` hello hi ``` The cursor is on `o` in "hello". `j` puts the cursor on the EOL besides the `i`...

Now I tried. I see it's not working.

The linting fails although we haven't touched [`_index.scss`](https://github.com/lichess-org/lila/blob/master/ui/opening/css/_index.scss). After running `git pull origin support-iccf-notation` I still don't have the file on the local machine.

Promoting is now possible via e. g. `27281`.

Could someone point me to the file where we handle sounds when making an action in a game for example resigning?

https://github.com/lichess-org/lila/blob/19bd7a0bafb87520125cd0e883467747ca67fa69/ui/analyse/src/view.ts#L134-L165 This code provides the functionality for the analysis page. Compared to https://github.com/lichess-org/lila/blob/19bd7a0bafb87520125cd0e883467747ca67fa69/ui/analyse/src/study/studyShare.ts#L84 the signature differs by the type of `ctrl`. So we cannot copypaste the code because `StudyShareCtrl` doesn't...

We cannot rely on `ctrl.pgnInput` without extending `StudyShareCtrl`. The user experience should be similar to the one in the analysis page.