EndilWayfare

[EDIT: rq. impl isNumberMatch] Equivalent `PhoneNumber`s are not equal if the source of their country code is different

4

Because `Eq` is derived for `PhoneNumber`, this happens: ```rust let full = "+1-800-555-1234".parse().unwrap(); let equivalent = `phonenumber::parse(Some(phonenumber::country::US), "800-555-1234").unwrap(); // false full == equivalent; ``` `phonenumber::country::Code` stores the `u16` as well...

impl `From<FlagSet<F>> for F::Type`?

1

Obviously, from a pure-Rust standpoint, I think it makes sense to stay in the typecheck-guaranteed land of `FlagSet`: just think in terms of "a set of flags", and "it's a...

Hey, sweet crate by the way! Soooo glad I don't have to reinvent the wheel on this one. Unless I'm missing something, a few statements on the `flagset::flags` doc page...

This is about: - [ ] A typo - [x] Innaccurate/misleading documentation (e.g. technically incorrect advice) - [ ] Undocumented code - [x] Outdated documentation - [ ] Other **Problem**...

**Problem** `yew` 0.21 declares dependency on both `gloo` 0.10 and `prokio` 0.1.0, but `prokio` 0.1.0 depends on `gloo` 0.8. 0.8 and 0.10 are semver incompatible, so both versions are compiled....

Should `BStr` have an `into_raw`, some way to purposefully leak?

1

If you're implementing a function that returns a string to foreign COM callers, you [should not deallocate](https://docs.microsoft.com/en-us/cpp/atl-mfc-shared/allocating-and-releasing-memory-for-a-bstr?view=msvc-160&viewFallbackFrom=vs-2019) the returned BSTR. Since we can't pass a `wio::BStr` across the boundary, we'd...

First off, thanks for this crate. It is a _lifesaver_ dealing with `winapi`! As much as [`windows`](https://github.com/microsoft/windows-rs) is poised to be a worthy successor to the "autogenerated low-level bindings to...

Is using the gtk widgets both as user-facing display and program-facing source-of-truth "the good idea", or is it just a first-order solution used to not introduce too many ideas at...

Suggestion: Consider migrating from `xdg` to `directories` or `dirs` for greater portability

1

I know I'm probably in the minority of people who develop in Rust _primarily_ for Windows, but I'm sure GTK app developers would like to target Windows and Mac as...

Update to GTK-rs 0.14

2

The last code listing in [Chapter 1.4](https://mmstick.github.io/gtkrs-tutorials/1x04-event-driven.html) panics for me. `gtk-3.0.lib`: 3.24.28 `glib-2.0.lib`: 2.68.1 `rustc`: 0.53.0 `gtk`: 0.14.0 `glib`: 0.14.2 Downgrading to `gtk = 0.9`, the version used in [Chapter...