Christopher Grebs

Results 21 comments of Christopher Grebs

Maybe worth looking into GitHub Actions regarding all or some of these steps. On Thu, Feb 20, 2020, at 3:44 PM, Mathieu Pillard wrote: > Updates to libraries in this...

This should be done with the `parse-json` library that adds more advanced error handling and actually parses the `error.message` we are already catching to something more useful. Unfortunately node doesn't...

This is about adding a test that adds a new webext fixture with a `.eslintrc` that tries to override our default values set by our `JavaScriptScanner` (https://github.com/mozilla/addons-linter/blob/master/src/scanners/javascript.js#L38-L58) by using all...

@rpl @wagnerand thanks a lot for looking into that, that should indeed be fixed then

It'd be great to either decide if it's feasible to implement before AMO moves to `/sign/file` endpoint or if I should keep the current implementation. An advantage would be that...

No, this is about pulling `serialNumber` from the actual pkcs7 `content` part (`signer_info.sid.issuer.serial_number`)

Related to https://github.com/mozilla/addons/issues/4567

We're officially only testing against Python 2.7, 3.5 and 3.6. Unfortunately, I don't have time to also maintain Python 3.4, so if you need support for it please feel free...

Ugh, indeed. I'll have a look at this shortly.