Benjamin Woosley

Hey there, I made some improvements to spatial adapter to get it working under Rails 3.1.0 for my own use, and posted about fork here: #26 Several people have confirmed...

refactor: Remove redundant definitions

2

These were identified via `-Wshadow` in #29485, see the commit messages for the associated compiler message.

Don't update if unchanged

2

This reduces the number of cases in which the contents are re-rendered, specifically handling the `source` content case and the single unchanged string child case.

Add clarification on set_context types

1

This api has undocumented requirements on the type of the value, particularly, being a hash. This should be documented so that callers can be appraised of the requirement without inspecting...

Custom mining fee is not properly translated due to incorrect transaction size estimate

1

I set a custom mining fee of 1 sat/b, and it was rejected due to network rules. Then set the value to 2, and it passed, but on a the...

build-ios.sh fails with //go:build comment without // +build comment

2

Full output: ```bash % gomobile bind -iosversion=12.4 -target=ios -tags="ios experimental signrpc walletrpc chainrpc invoicesrpc routerrpc backuprpc peerrpc submarineswaprpc breezbackuprpc" -o build/ios/bindings.xcframework -ldflags="-s -w" github.com/breez/breez/bindings gomobile: iossimulator/arm64: go build -tags ios,experimental,signrpc,walletrpc,chainrpc,invoicesrpc,routerrpc,backuprpc,peerrpc,submarineswaprpc,breezbackuprpc...

init: Fixes for file descriptor accounting

5

This rebases and revises #16003 for clarity of review. Aims to fix #18911.