fsr-rs

fsr-rs copied to clipboard

### Checklist * [x] I have read the [Contributor Guide](../../CONTRIBUTING.md) * [x] I have read and agree to the [Code of Conduct](../../CODE_OF_CONDUCT.md) * [x] I have added a description of...

ComfyFluffy

As it just lists 6 source files that doesn't change. And we generally prefer to not use dependencies that interact with the file system beyond `cap-std`.

repi

We want to let LLVM do name mangling here so it prefixes the link name automatically with `_` on macos. Currently i manually remove it.

VZout

we started with focus on FSR2 to enable using that, which is essentially there now, after cleaning that up and actively using it we should look into FSR3 as well!...

repi

Right now it is vendored under `fsr-sys/FidelityFX-FSR2`, but would be easier to update, and to make sure we don't do repo-specific changes in it, if it is a git submodule...

repi

```sh $ cargo test ---- fsr/src/lib.rs - (line 5) stdout ---- error: expected one of `!`, `,`, `.`, `::`, `?`, `{`, `}`, or an operator, found `message_callback` --> fsr/src/lib.rs:25:5 |...

repi

These functions do not have `# Safety` documentation to describe how to uphold safety invariants when calling them, clippy finds it: ``` warning: unsafe function's docs miss `# Safety` section...

repi

Was building on Linux and get the following compiler warnings outputted that we should fix, or most likely suppress in the build script. ``` warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:190:63: warning: missing initializer for...

repi