fsr-rs icon indicating copy to clipboard operation
fsr-rs copied to clipboard
verified publisher icon EmbarkStudios

C++ compile warnings when building

Open repi opened this issue 2 years ago • 0 comments

Was building on Linux and get the following compiler warnings outputted that we should fix, or most likely suppress in the build script.

warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:190:63: warning: missing initializer for member ‘FfxConstantBuffer::data’ [-Wmissing-field-initializers]
warning:   190 |     {sizeof(Fsr2GenerateReactiveConstants) / sizeof(uint32_t)}};
warning:       |                                                               ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:190:63: warning: missing initializer for member ‘FfxConstantBuffer::data’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:190:63: warning: missing initializer for member ‘FfxConstantBuffer::data’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:190:63: warning: missing initializer for member ‘FfxConstantBuffer::data’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘FfxErrorCode patchResourceBindings(FfxPipelineState*)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:352:37: warning: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘long unsigned int’ [-Wsign-compare]
warning:   352 |         for (mapIndex = 0; mapIndex < _countof(srvResourceBindingTable); ++mapIndex)
warning:       |                                     ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:366:37: warning: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘long unsigned int’ [-Wsign-compare]
warning:   366 |         for (mapIndex = 0; mapIndex < _countof(uavResourceBindingTable); ++mapIndex)
warning:       |                                     ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:380:37: warning: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘long unsigned int’ [-Wsign-compare]
warning:   380 |         for (mapIndex = 0; mapIndex < _countof(cbResourceBindingTable); ++mapIndex)
warning:       |                                     ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘FfxErrorCode fsr2Create(FfxFsr2Context_Private*, const FfxFsr2ContextDescription*)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning:   586 |     };
warning:       |     ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initDataSize’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:586:5: warning: missing initializer for member ‘Fsr2ResourceDescription::initData’ [-Wmissing-field-initializers]
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:596:217: warning: missing initializer for member ‘FfxResourceDescription::flags’ [-Wmissing-field-initializers]
warning:   596 |         const FfxResourceDescription resourceDescription = {resourceType, currentSurfaceDescription->format, currentSurfaceDescription->width, currentSurfaceDescription->height, 1, currentSurfaceDescription->mipCount};
warning:       |                                                                                                                                                                                                                         ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘void scheduleDispatch(FfxFsr2Context_Private*, const FfxFsr2DispatchDescription*, const FfxPipelineState*, uint32_t, uint32_t)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:774:60: warning: missing initializer for member ‘FfxGpuJobDescription::<anonymous>’ [-Wmissing-field-initializers]
warning:   774 |     FfxGpuJobDescription dispatchJob = {FFX_GPU_JOB_COMPUTE};
warning:       |                                                            ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:729:97: warning: unused parameter ‘params’ [-Wunused-parameter]
warning:   729 | static void scheduleDispatch(FfxFsr2Context_Private *context, const FfxFsr2DispatchDescription *params, const FfxPipelineState *pipeline, uint32_t dispatchX, uint32_t dispatchY)
warning:       |                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘FfxErrorCode fsr2Dispatch(FfxFsr2Context_Private*, const FfxFsr2DispatchDescription*)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:801:65: warning: missing initializer for member ‘FfxGpuJobDescription::<anonymous>’ [-Wmissing-field-initializers]
warning:   801 |         FfxGpuJobDescription clearJob = {FFX_GPU_JOB_CLEAR_FLOAT};
warning:       |                                                                 ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:995:65: warning: missing initializer for member ‘FfxGpuJobDescription::<anonymous>’ [-Wmissing-field-initializers]
warning:   995 |         FfxGpuJobDescription clearJob = {FFX_GPU_JOB_CLEAR_FLOAT};
warning:       |                                                                 ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:814:20: warning: unused variable ‘currentCpuOnlyTableBase’ [-Wunused-variable]
warning:   814 |     const uint32_t currentCpuOnlyTableBase = isOddFrame ? FFX_FSR2_RESOURCE_IDENTIFIER_COUNT : 0;
warning:       |                    ^~~~~~~~~~~~~~~~~~~~~~~
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:815:20: warning: unused variable ‘currentGpuTableBase’ [-Wunused-variable]
warning:   815 |     const uint32_t currentGpuTableBase = 2 * FFX_FSR2_RESOURCE_IDENTIFIER_COUNT * context->resourceFrameIndex;
warning:       |                    ^~~~~~~~~~~~~~~~~~~
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:899:34: warning: variable ‘resourceDescReactiveMask’ set but not used [-Wunused-but-set-variable]
warning:   899 |     const FfxResourceDescription resourceDescReactiveMask = context->contextDescription.callbacks.fpGetResourceDescription(&context->contextDescription.callbacks, context->srvResources[FFX_FSR2_RESOURCE_IDENTIFIER_INPUT_REACTIVE_MASK]);
warning:       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘FfxErrorCode ffxFsr2ContextGenerateReactiveMask(FfxFsr2Context*, const FfxFsr2GenerateReactiveDescription*)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:1333:60: warning: missing initializer for member ‘FfxGpuJobDescription::<anonymous>’ [-Wmissing-field-initializers]
warning:  1333 |     FfxGpuJobDescription dispatchJob = {FFX_GPU_JOB_COMPUTE};
warning:       |                                                            ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp: In function ‘FfxErrorCode generateReactiveMaskInternal(FfxFsr2Context_Private*, const FfxFsr2DispatchDescription*)’:
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:1399:60: warning: missing initializer for member ‘FfxGpuJobDescription::<anonymous>’ [-Wmissing-field-initializers]
warning:  1399 |     FfxGpuJobDescription dispatchJob = {FFX_GPU_JOB_COMPUTE};
warning:       |                                                            ^
warning: FidelityFX-FSR2/src/ffx-fsr2-api/ffx_fsr2.cpp:1356:20: warning: unused variable ‘commandList’ [-Wunused-variable]
warning:  1356 |     FfxCommandList commandList = params->commandList;
warning:       |                    ^~~~~~~~~~~

repi avatar Sep 29 '23 09:09 repi