Elvin Efendi

Results 23 comments of Elvin Efendi

This work is being completed at: https://github.com/Shopify/lua-resty-upstream-healthcheck/pull/1

Is there any plan to implement setting `ssl_trusted_certificate` in the same manner(i.e `ngx_http_lua_ffi_ssl_ctx_set_trusted_cert`)? Motivation: When you need to use SSL(with client verification) in `init_worker` context with `timer.at` you have to...

@agentzh thanks for reviewing, I addressed your comments. > Also, please rebase to the latest git master. I don't see any conflict with the upstream master(there were some initially but...

@agentzh any more comment on this PR?

By default `peer.name`(an entry defined inside upstream block as `:`) is being passed to `tcpsock:sslhandshake` function as `server_name` which is used to validate the server name specified in the server...

> Will you please rebase to the latest git master? I'm seeing merge conflicts while rebasing it myself: Hmm I don't know why does it show conflict. There's no commit...

I'd also like to highlight that https://github.com/openresty/lua-resty-upstream-healthcheck/pull/36/commits/6731f959d146264e8ba1b5adbd41968deb0ae92e is not related to this PR, it is just included here because the downstream is Shopify fork's _master_. If you don't want to...

Thanks for the replies, it'd be great to have a page explaining benefits of writing a plugin in this framework than in Lua.

@zerkms thanks for bringing this up. I think the controller should not consider the the list of endpoints to be empty when the API server is down. Can you write...