Elvin Efendi

Results 23 comments of Elvin Efendi

I'd really like to keep the core as simple as possible. This sounds like a great feature to be implemented as a hook. That being said I'll review the code...

some nitpicks but the code looks good otherwise

> If this should be done via hooks, then maybe also the primary output should be hook instead, as to avoid special case. Having more consistent way of configuring outputs...

@ytti I'll try to handle it this week.

FWIW we are adding OCSP stapling feature to https://github.com/kubernetes/ingress-nginx and having `thisUpdate` and `nextUpdate` attributes exposed on the Lua land would be really useful for deciding cache validity.

I took an alternative stab at this: https://github.com/openresty/lua-resty-core/pull/296

For tests see https://github.com/openresty/lua-resty-core/pull/296#issuecomment-615883139

Here's the local test run: ``` > lua-resty-core (ocsp-nextupdate)$ docker run -w /app --rm -it -v ${PWD}:/app lua_ngx t/ocsp.t t/ocsp.t .. 1/258 TEST 17: no status req from client -...

cc @agentzh @thibaultcha

Can I get some feedback on this?