Elliot
Elliot
The Forge Proposal Simulator is designed to help eliminate bugs in governance proposals. It does this in two ways: 1. Explicitly ask the developer to write validations tailored to each...
Another benefit is you could consolidate and make your addresses system easier to use https://github.com/ethereum-optimism/superchain-ops/blob/main/tasks/sep/metal-001-MCP-L1/SignFromJson.s.sol#L396-L404 Instead would look more like this `addresses.getAddress("ADDRESS_NAME")`. https://docs.soliditylabs.io/forge-proposal-simulator/guides/multisig-proposal#setting-up-the-addresses-json
Where can we find the `ProtocolVersions` contract in the superchain ops or superchain registry repo? Searching this address [0x8062AbC286f5e7D9428a0Ccb9AbD71e50d93b935](https://etherscan.io/address/0x8062AbC286f5e7D9428a0Ccb9AbD71e50d93b935#readProxyContract) in the addresses.json file in superchain-registry shows no results. Looking in...
The most generic version of the `TransferOwnerTemplate` would accept a toml configuration file with values for both the new owner and contract whose ownership is being transferred.
> We should be able to automatically determine both `OWNER_SAFE` and `SCRIPT_NAME` from the `config.toml` file. I think it requires both the config.toml and solidity template files to determine which...
I can remove the OWNER_SAFE in the simulate command from this PR https://github.com/solidity-labs-io/superchain-ops/pull/30/files that way the user doesn't have to specify this value. I'll just remove the `--sender` flag
> I'm not sure we want to remove the `--sender` flag though. Doesn't it add value by running the simulation as the sender address? I don't think it adds any...
Ok, just confirmed we can simulate without needing to set the owner safe https://github.com/solidity-labs-io/superchain-ops/pull/30/files PR 30 also includes an example command if you'd like to test it on your machine.
This sounds like a perfect use case for FPS! I don't have context on how you guys structure your repositories or tests. Would you be able to summarize things here...
Our current thoughts on how to run monorepo forge tests in the superchain ops repo post task execution: 1. setup anvil mainnet fork 2. run the tasks that are in...