Steven Pham

Results 21 comments of Steven Pham

> Looks like CI is still failing: > > https://github.com/fitzgen/bumpalo/runs/7286188380?check_suite_focus=true#step:5:342 > > ``` > failures: > ---- oom_instead_of_bump_pointer_overflow stdout ---- > Layout::from_size_align errored: invalid parameters to Layout::from_size_align > note: test...

> > Looks like CI is still failing: > > https://github.com/fitzgen/bumpalo/runs/7286188380?check_suite_focus=true#step:5:342 > > ``` > > failures: > > ---- oom_instead_of_bump_pointer_overflow stdout ---- > > Layout::from_size_align errored: invalid parameters to...

Toying with the latest nightly it seems that `Layout::size_from_align` panics with a lot of values that `stable` won't with. Namely values of size near `usize::MAX`. I'm not sure if this...

I asked on the rust zulip and it seems like there is a new requirement for `Layout::from_size_align` that the size value must fit in an `isize` from this [PR](https://github.com/rust-lang/rust/pull/95295) which...

I made an issue for the breakage with a tentative suggested change

Hey @fitzgen , just pinging in case this slipped by your email 😃

Changing ```rust let size = usize::MAX - p + 1; ``` to ```rust let size = (isize::MAX as usize) - p + 1; ``` on line 74 of `tests.rs` gets...

Hello! I tried my hand at implementing this feature, tell me what you think

> I think this should pass CI now if rebased Seems like it does!

I had a great time working on this PR, thanks for your work reviewing it and maintaining this crate! 😄