Steven Pham
Steven Pham
Hey @fitzgen, just checking in to see if you've had time to review the latest changes? No worries if you're busy though 😃
All the comments should be resolved with these commits 😄
On an unrelated note, between the time I opened the PR and now I started project selection for my 4th year project in school and am looking at doing work...
> All the comments should be resolved with these commits 😄 I just have one concern regarding how allocation limits interact with the value for the minimum chunk size allocation....
> > I just have one concern regarding how allocation limits interact with the value for the minimum chunk size allocation. If a limit is set that is below `DEFAULT_CHUNK_SIZE_WITHOUT_FOOTER`,...
@fitzgen Since I'm not sure if plain comments trigger notifications
I took a stab at fixing this problem by factoring out the logic for determining the final size of chunk allocations so that the code in `alloc_layout_slow` could determine the...
I'm realizing now that this change causes some memory details about the new chunks to be calculated twice in a lot of cases so I'll make a change to avoid...
> I'm realizing now that this change causes some memory details about the new chunks to be calculated twice in a lot of cases so I'll make a change to...
@fitzgen Should be good now, I ran the tests on `1.54.0`