Giordano Ricci
Giordano Ricci
@dprokop @leventebalogh @joshhunt can you please retake a look at this? it's already approved but i did some changes to fix a couple of tests. also i'm not really comfortable...
@joshhunt like a charm, thank you for looking at this! ❤️
@grafana/backend-platform any chance i can get a review on this?
note that only using `aria-expanded` is not sufficient, it should also be paired with `aria-controls` that references the controlled element. see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded#buttons for example
it tells assistive technologies which section of the document is controlled by that toggle button (and in turn, which control controls a section). section stating it's being controlled by a...
looks good! one thing i noticed while testing though is that we can end up in a situation where IDs are duplicated, for instance in Explore split view when queries...
FWIW I'm experiencing exactly what @giubatt mentioned after upgrading typescript to `4.2.2`, downgrading it back to `4.1.5` seems to "fix" this
@ifrost mind reviewing this again? i pushed some other changes
@radiorental is there any data related to those events else we are interested in? ie. source & target datasource when creating/updating/deleting? readOnly status when expanding details? do we also want...
@doniacld here you go :) https://github.com/tinygo-org/drivers/pull/381