rust-elements

rust-elements copied to clipboard

Secp operations during txid computation

2

In a performance profile in a downstream project I noticed `txid()` is taking too much time even considering it's an expensive computation, in the flame graph there were calls to...

RCasatta

close #194

RCasatta

Make it work on WASM

3

I think the only issue is deal with rand ``` cargo check --target wasm32-unknown-unknown error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js"...

RCasatta

inverted fields in `hex::Error::InvalidLength`

1

I am testing https://github.com/ElementsProject/rust-elements/pull/188 in a downstream lib https://github.com/ElementsProject/rust-elements/blob/613204f38eeb8f4fcc767042197fd763965f057a/src/hex.rs#L33 I think the `expected, got` comment is wrong and the values used in the Display implementation are inverted. I say so...

RCasatta

confidential: Don't reverse explicit values for serde

5

So this is a breaking change. It might affect people actually using the serde serialization of `confidential::Value::Explicit` right now. Which is really unfortunate. But IMO this is a bug. We...

stevenroose

PSET Examples broken

9

It seems that the examples are broken on master. Running this produces various compilation errors: ``` cargo test --features serde ```

stevenroose

Change error type of Encodable to io::Error like bitcoin does

4

stevenroose

Minor API pain-points

1

These are things that are easy to workaround downstream, but would one-liner if we had upstream support. I will update the list as I find more things: 1) Direct API...

sanket1729

One shot cargo fmt

8

I think we should do it earlier when the diff is smaller and the project is smaller in scope. Otherwise, it becomes a big task to do it file by...

sanket1729

Ignore dependabot security alert

1

https://github.com/ElementsProject/rust-elements/security/dependabot/1 was dismissed by me with the note "Severe for this project". serde_cbor was only used in tests. serde_cbor was only used in test. Opening an issue for people to...

sanket1729