rust-elements icon indicating copy to clipboard operation
rust-elements copied to clipboard

Fix WASM build and add a job in CI

Open RCasatta opened this issue 1 year ago • 3 comments

close #194

RCasatta avatar Jan 23 '24 15:01 RCasatta

Note downstream you can use this without the dev-dep obviously, this is just needed to enforce wasm check in CI so that we are not breaking it in the future

RCasatta avatar Aug 22 '24 08:08 RCasatta

LGTM, but would this check have actually caught the getrandom thing? My understanding is that if you compile without the js feature you'll get a runtime panic, so just running cargo check won't have noticed it.

Regardless, this CI job is an improvement over having nothing.

apoelstra avatar Aug 22 '24 15:08 apoelstra

It seems it's a compile time check and without the getrandom thing the job would fail https://github.com/RCasatta/rust-elements/actions/runs/10578325188/job/29308193852?pr=2

RCasatta avatar Aug 27 '24 12:08 RCasatta