Tomasz Marek Sulima

Results 32 comments of Tomasz Marek Sulima

**Edit**: @philss: Looks better, but it should be already implemented, so developers not need to care about replace.

@aphillipo: yup, this way or #37. btw. If you can explain me how parsers should work, like: > best way is to create regex, you can find sample/demo patterns at...

@philss and @aphillipo: Did you know `:xmerl` and `:xmerl_scan`? For example see [erlang docs](http://erlang.org/doc/man/xmerl.html). Maybe it's what we are looking for that we can easily extend? ```elixir Erlang/OTP 19 [erts-8.1]...

@philss: Ok, I see your point. I see that your way ("bridge") is faster to implement. I don't know how exactly will work. Will it be as fast (with that...

It would be awesome to have something like this: ```elixir %Floki.Leaf.Comment(content: "comment content"} %Floki.Leaf.Node{attributes: [], children: [], events: [], name: "p", styles: []} # events and styles are optional (I...

@alfert: I don't know if I understand this correctly, but for me (I'm new in Elixir too) it looks like (in this example) that macro calls are never covered if...

How it's going to work? If I remember correctly composite types have fixed number of attributes, right? Did you mean: `{:unused, nil} | {:next, id} | {:finished, nil}`? If so...

@simonprev: Both original and your code have a small bug. Please replace: ```elixir String.replace(acc, "%{#{key}}", to_string(value)) ``` to: ```elixir key_pattern = "%{#{key}}" if String.contains?(acc, key_pattern) do String.replace(acc, key_pattern, to_string(value)) else...

@simonprev Also I forgot to mention that you should set app `env` (default library configuration), because it fails without any configuration extra. I have tested it and I think that's...

@simonprev: Please take a look at [stackoverflow question](https://stackoverflow.com/questions/43302779/set-default-application-configs-for-elixir-packages).