Jacob Finkelman
Jacob Finkelman
I parameterized `basic_dcm` to run with normalization and 3 different regularizations. Then looked through all the newly failing tests. This sussed out 2 places where I did not pass the...
merged and ci is green. Thoughts? What else would you like to see before accepting?
Good Catch! Maybe we should add a test to keep this from breaking again?
I noticed when experimenting with this that sometimes outgoing requests redact the authenticate header, and other requests do not. We should probably consistently redact the header.
Sorry. I should have spent more time drafting that message. Yes I was talking about the `Authorization` header in log messages. When running `cargo/target/release/cargo publish --registry=myregistry -Z sparse-registry -Z registry-auth...
@jonathanstrong thank you very much for trying this out! The registry token field is already stable, this PR only makes it more useful. I'm worried that your feedback will get...
@arlosi do we have good testing for "Making sure that the correct API token goes to the correct server in places where we were doing it wrong before. (And confirming...
The changes look good, and well tested. I would just approve, but this is insta-stable. So I'm going to ask for some checkmarks. By the way, rereading the RFC I'm...
@bors r=ehuss