Jakub Wąsik

Results 9 comments of Jakub Wąsik

Well I meant typings mostly :)

Had the same thought when I saw the repo

@pwlmaciejewski will you be looking into TypeScript version?

# I've quickly mocked something like this: ```ts // index.d.ts /// // fs filepath: PathLike | number; // type PathLike = string | Buffer | URL; type Filepath = string...

Tbh it is infering nicely most of the stuff from the dependencies, tho no direct typings therefore TS complains about lack of them.

No problem. No it is not causing any problems. I'll try to do it as soon as I can ;)

I've noticed in the commit history that the previous typings were reverted. [Revert "added typings"](https://github.com/gustf/js-levenshtein/commit/3c9a450a127801ab7de93de35838d3ec4d4727e4) Why?

inb4 > fixes missing `return` > writes a xxx long PR description 😅

This `hexToBinary` change breaks the tests