Edmond Chui

Results 13 issues of Edmond Chui

Not sure if it is Android specific, but testing on both 2.3.6 and 4.1.1 devices causes this Exception. E/AndroidRuntime(10087): java.lang.IllegalArgumentException: Bad limit (capacity 57): 73 E/AndroidRuntime(10087): at java.nio.Buffer.limitImpl(Buffer.java:312) E/AndroidRuntime(10087): at...

### Summary Add extension point to delegate component rendering to an override-able function, similar to `getConstructor`. Also add callback to component unmount This allows custom implementations that renders parent wrapper...

enhancement
help wanted

## requires https://github.com/reactjs/react-rails/pull/1064 to be merged ### Summary Automatically hot reload all components rendered with `react_ujs` without source file changes. Existing support requires manually wrapping all components with `hot(App)`. This...

enhancement
help wanted

Summary: Changelog: [General][Fixed] Fix order of Metro hotkey console messages # Existing Key handler is printing messages to the console _after_ it has been processed, this causes error messages to...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: Changelog: [internal] Add support for an unstable query param. Arbitrary string supported as we anticipate multiple values. Differential Revision: D53824155

CLA Signed
p: Facebook
Partner
fb-exported

Summary: Changelog: [Internal] Differential Revision: D56610268

CLA Signed
p: Facebook
Partner

Summary: Changelog: [Internal] No longer generates launch ID. Caller of `/open-debugger` is now responsible. Differential Revision: D55164645

CLA Signed
p: Facebook
Partner

Summary: Changelog: [General][Removed] `launchId` query param for `/debugger-frontend` is no longer generated automatically for each `/open-debugger` call. Caller of `/open-debugger` is now responsible for generating the `launchId`, which will be...

CLA Signed
p: Facebook
Partner

Summary: Changelog: [General][Removed] `launchId` query param for `/debugger-frontend` is no longer generated automatically for each `/open-debugger` call. Caller of `/open-debugger` is now responsible for generating the `launchId`, which will be...

CLA Signed
p: Facebook
Partner