react-native
react-native copied to clipboard
facebook
disable "Open Debugger" menu item if the bundler is disconnected
Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected
Existing
In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected.
{F1451833462}
In this PR
The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript"
{F1451834019}
Reference
- There are existing checks, but they're async. We don't need the check to be accurate; and we don't want to delay the dev menu from opening
- Also on iOS: D53354110
Differential Revision: D53428914
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 17,233,732 | +448 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 20,600,535 | +424 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: db066acfe3994787d706ad082ce718a91b8249f5 Branch: main
This pull request was successfully merged by @EdmondChuiHW in 7afc8b8623cc499c3054b9fb5b08cc2b65edb19c.
When will my fix make it into a release? | Upcoming Releases
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}