Ed Schouten

Results 164 comments of Ed Schouten

> Right. But the generated Go code would still flip around between a struct and a slice and thus, is a breaking change for the Go module. Which is completely...

> As I read that link, the "last one wins" behavior is only true for primitive types--strings and numbers. For nested messages, as is the case here, the subfields will...

> I think there's still some awkwardness with ordering--IIRC there's no guarantee of the serialization order, so servers expecting a singular field could technically end up with either entry 0...

How does this work with remote execution? If an output file gets placed in the input root of a subsequent action, how would the worker know which shard to query?...

Just to clarify: are we talking about [build_event_stream.proto](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto) a.k.a. Build Event Protocol, or [publish_build_event.proto](https://github.com/googleapis/googleapis/blob/master/google/devtools/build/v1/publish_build_event.proto) a.k.a. Build Event Service? Standardizing the latter (BES) might make sense. The former (BEP), I'm not...

My concern is that if we attempt to standardize anything that is in excess of the Build Event Service, it would severely suffer from an [inner-platform effect](https://en.wikipedia.org/wiki/Inner-platform_effect).

I'd actually be in favor of keeping the "bazel_" prefix. As the name implies, BCR is a central registry. There are many systems apart from Bazel that have "remote APIs".

> > Looking at the protocol, we also have the digest_function field in requests, with the following note: > > ``` > > // The digest function the server must...

> ### [email protected] > Maintainers: @EdSchouten > > * [[email protected] - :centos: CentOS 7 - Run example test module](https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72#019367bc-a4c1-491f-9ea4-e0a7f3f5ade6) > * [[email protected] - :debian: Debian 10 Buster (OpenJDK 11, gcc...

Note that the description of #1802 says that it fixes this issue, it does not. This issue is still reproducible with the latest version of Gazelle.