EdJoPaTo

Results 355 comments of EdJoPaTo

It might be a good idea to support [cargo-binstall](https://github.com/cargo-bins/cargo-binstall) then everything and everyone like users, CI and so on with cargo-binstall can just install cargo-spellcheck. No custom github action for...

The idea of a `TreeItem` is to only keep a reference to its content rather than moving the full content into the item. That's why the `TreeItem` has a reference...

I hope something like this is not necessary, and I prefer improving the performance rather than using something like this. ([More detailed answer in the related issue](https://github.com/EdJoPaTo/tui-rs-tree-widget/issues/31#issuecomment-2088770092)). So I would...

> Changing the `YOUTUBE_EMBED_URL_OVERRIDE` will only take effect on new articles. That's good to know. So it looks like its working as intended? I expected this to be done when...

I played around with the new v9 and its awesome to have types now! The use of the sub-export `wikibase-sdk/wikidata.org` is a neat idea! I have a few ideas and...

Another thing would be to make all the function options readonly. This way the caller can be sure the content is not changed. ```diff export interface GetEntitiesOptions { - ids:...

Found some inconsistent parameters of `wdk.simplify.sparqlResults`: the second argument is missing (The one with `{minimize: true}`). `simplifySparqlResults` still has the second argument so it got lost on the interface. (#91...

Except my request for readonly options I think everything here is solved or has an open PR. Maybe close this issue?

@Ethiraric This is not fully solved. Reviewers of the PR: @GuillaumeGomez @blyxyas Should this be reopened or a new issue created? ```rs pub struct Data { pub const fn new(value:...

> It's in an area of the code I did not change. Just want to make sure it was not understood as criticism. :innocent: I just noticed earlier today that...